Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cosmos interchain service cleanup #9810

Merged
merged 6 commits into from
Jul 31, 2024
Merged

chore: cosmos interchain service cleanup #9810

merged 6 commits into from
Jul 31, 2024

Commits on Jul 31, 2024

  1. feat: cosmosInterchainService.makeAccount accepts address opts 

    - expose an optional argument for providing different ica channel parameters, such as version and ordering
    @0xpatrickdev
    0xpatrickdev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8cad5e3 View commit details
    Browse the repository at this point in the history

  2. refactor: unnecessary powerStore abstraction

    @0xpatrickdev
    0xpatrickdev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1989138 View commit details
    Browse the repository at this point in the history

  3. feat: cosmosInterchainService.provideICQConnectiont accepts version 

    - allow caller to specify optional version string
- update persitence logic to key off of ${controllerConnectionId}:${version}
    @0xpatrickdev
    0xpatrickdev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3dc6bb6 View commit details
    Browse the repository at this point in the history

  4. chore: provideICQConnection should always return a vow 

    - in the case of a potential early synchronous return, still return a vow
    @0xpatrickdev
    0xpatrickdev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d4101a4 View commit details
    Browse the repository at this point in the history

  5. fix(network-fakes): do not rely on source_port for channelId 

    - a port can be reused to create multiple channels. requesting a new channel with the same port should result in a new channel id
- uses channelCount to increment channelID. keeps a map of channels per connection to determine counterpartyChannelID
    @0xpatrickdev
    0xpatrickdev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    00fe7ed View commit details
    Browse the repository at this point in the history

  6. feat: use a single port for all icq connections 

    - changes logic in provieICQConnection to lazily request a port on the first request, and reuse it in subsequent requests. since the channel
is ordered, timeouts and query errors will not affect subsequent queries and this can be considered safe
- closes #9317
    @0xpatrickdev
    0xpatrickdev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d80a57c View commit details
    Browse the repository at this point in the history