[AI] Implements missing effects simulators #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
============================================
+ Coverage 96.22% 96.26% +0.04%
- Complexity 8631 8847 +216
============================================
Files 1357 1385 +28
Lines 21912 22534 +622
Branches 1318 1390 +72
============================================
+ Hits 21084 21693 +609
- Misses 638 640 +2
- Partials 190 201 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Null test for code coverage ?
| @@ -231,6 +232,13 @@ public double selfBoost() { | |||
| return selfBoost; | |||
| } | |||
|
|
|||
| /** | |||
| * The score of the invoked creature | |||
| } | ||
|
|
||
| if (totalMaxLife == 0) { | ||
| return 1.0; |
There was a problem hiding this comment.
Never test ? (Code coverage report)
...test/java/fr/quatrevieux/araknemu/game/fight/ai/simulation/effect/SetStateSimulatorTest.java
Show resolved
Hide resolved
vincent4vx
changed the title
ArleeDev
pushed a commit
to ArleeDev/Araknemu
that referenced
this pull request
Mar 7, 2024
…issing-effects [AI] Implements missing effects simulators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.