Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/ari-1618 #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feature/ari-1618 #1

wants to merge 7 commits into from

Conversation

0xWhiteleaf
Copy link
Member

@0xWhiteleaf 0xWhiteleaf commented Nov 5, 2024 •
edited
Loading

  • forge install: openzeppelin-foundry-upgrades
  • forge install: openzeppelin-contracts-upgradeable
  • feat(contract): ArianeeSmartAsset
  • test: ArianeeSmartAsset
  • fix: ArianeeSmartAsset
  • feat: ArianeeSmartAssetUpdate

@0xWhiteleaf 0xWhiteleaf changed the title feature/ari 1618 feature/ArianeeSmartAsset Nov 5, 2024
@0xWhiteleaf 0xWhiteleaf changed the title feature/ArianeeSmartAsset feature/ari-1618 Nov 12, 2024
@mvaullerin mvaullerin force-pushed the feature/ari-1618 branch 2 times, most recently from 27cd081 to 6b073c2 Compare November 12, 2024 15:01
mvaullerin
mvaullerin reviewed Nov 13, 2024
View reviewed changes
src/V0/ArianeeSmartAsset.sol
*/
function destroy(
uint256 _tokenId
) external whenNotPaused {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove this method for now, and add it later since the contract is now upgradable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaullerin mvaullerin mvaullerin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xWhiteleaf @mvaullerin