Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dry run mode to nostrss core #88

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Add dry run mode to nostrss core #88

merged 3 commits into from
Jul 17, 2024

Conversation

Asone
Copy link
Owner

@Asone Asone commented Jul 16, 2024 •
edited
Loading

Adds the --dry-run flag to nostrss core application.

The feature should run and be valid. I'll run a few tests on a local relay first to ensure everything runs as expected before merging and releasing it.

TESTS :

  • Program behaves as expected on LAN relay
  • Program behaves as expected on local relay
  • Program behaves as expected on remote relay

@Asone Asone linked an issue Jul 16, 2024 that may be closed by this pull request
Add dry-run mode to nostrss core #87
Closed
@Asone Asone marked this pull request as ready for review July 17, 2024 19:32
@Asone Asone self-assigned this Jul 17, 2024
@Asone Asone added the enhancement New feature or request label Jul 17, 2024
@Asone Asone merged commit 00cada5 into main Jul 17, 2024
7 checks passed
@nherbin-ma nherbin-ma mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Asone Asone

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dry-run mode to nostrss core
1 participant
@Asone