psplash: Add support for animated gifs during boot #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has now the ability to disable the progressbar, so no need to patch psplash anymore.
MagneFire
force-pushed
the
psplash-gif
branch
from
92c33f3
to
8edcf79
Compare
Add support for showing an animated gif located at /usr/share/psplash.gif. This is enabled by default and can be disabled on a per device basis if this proves problematic on some platforms. Many credits go to @eLtMosen for providing the animated gifs! This work is based on tano-systems/psplash-tn@67394ea Co-authored-by: Timo Könnecke <koennecke@mosushi.com>
… fix screen noise issue. On some watches (Mostly msm8909 and Android kernels 8.0 and up) double buffering results in only garbled pixels. Disabling double buffering and using FBIOPAN_DISPLAY solves this partly, be the framebuffer needs to be opened once to workaround this completely.
Some watches need some assistance to setup the framebuffer. Adding the same code into psplash alone does not solve this. It needs to be a separate binary that is executed before psplash.
MagneFire
force-pushed
the
psplash-gif
branch
from
8edcf79
to
7e24fc7
Compare
|
Eheh this is very cool :) Let's see if we can come up with more cool animations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for showing an animated gif located at /usr/share/psplash.gif.
This is enabled by default and can be disabled on a per device basis if this proves problematic on some platforms.
Many credits go to @eLtMosen for providing the animated gifs!
This work is based on tano-systems/psplash-tn@67394ea
Demo:
psplash-gif.mp4
Also worth noting that if a watch needs a different solution the following can be used in a
bbappendrecipe:Now also distribute the
Disable-double-buffering.patchpatch here instead of the different watch layers (https://github.com/AsteroidOS/meta-ray-hybris/blob/master/recipes-core/psplash/psplash/0001-Disable-double-buffering.patch, https://github.com/AsteroidOS/meta-skipjack-hybris/blob/main/recipes-core/psplash/psplash/0001-Disable-double-buffering.patch, also forsawfish(oreo +) andcatfish).Additionally, instead of restarting psplash and starting msm-fb-refresher with some delay. We can also start msm-fb-refresher before psplash to solve the garbled display issue (AsteroidOS/asteroid#101 (comment)).