Skip to content

Commit

Permalink
[BugFix] Image overlay username could overlap the image (#4891)
Browse files Browse the repository at this point in the history
  • Loading branch information
@emlynmac
emlynmac authored Aug 30, 2024
1 parent 5680829 commit 964ac5f
Show file tree
Hide file tree
Showing 43 changed files with 19 additions and 2 deletions.
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-46007d21-e47f-4e61-a90c-05570411e301.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y Fixes",
"comment": "Fix Message status announcement sometimes takes priority over \"Message is deleted\" one",
"packageName": "@azure/communication-react",
"email": "3941071+emlynmac@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-46007d21-e47f-4e61-a90c-05570411e301.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "A11y Fixes",
"comment": "Fix Message status announcement sometimes takes priority over \"Message is deleted\" one",
"packageName": "@azure/communication-react",
"email": "3941071+emlynmac@users.noreply.github.com",
"dependentChangeType": "patch"
}
3 changes: 1 addition & 2 deletions packages/react-components/src/components/styles/ImageOverlay.style.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const headerStyle: IStyle = {
fontSize: 'inherit',
margin: '0',
width: '100%',
height: '3.5rem',
minHeight: '3.5rem',
flexDirection: 'row',
justifyContent: 'space-between',
padding: '0.25rem 0.75rem'
Expand All @@ -80,7 +80,6 @@ export const headerStyle: IStyle = {
export const titleBarContainerStyle: IStyle = {
flexDirection: 'row',
justifyContent: 'start',
flexWrap: 'wrap',
alignContent: 'center',
alignItems: 'center'
};
Expand Down
Binary file modified ...Overlay.spec.tsx-snapshots/image-overlay-loading-stage-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ec.tsx-snapshots/image-overlay-loading-stage-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pec.tsx-snapshots/image-overlay-loading-stage-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...geOverlay.test.ts-snapshots/image-overlay-loaded-stage-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...test.ts-snapshots/image-overlay-loaded-stage-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....test.ts-snapshots/image-overlay-loaded-stage-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...eOverlay.test.ts-snapshots/image-overlay-loading-stage-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...est.ts-snapshots/image-overlay-loading-stage-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...test.ts-snapshots/image-overlay-loading-stage-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...tic/ImageOverlay.test.ts-snapshots/image-overlay-modal-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...verlay.test.ts-snapshots/image-overlay-modal-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...Overlay.test.ts-snapshots/image-overlay-modal-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...rlay.test.ts-snapshots/image-overlay-modal-broken-link-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts-snapshots/image-overlay-modal-broken-link-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....ts-snapshots/image-overlay-modal-broken-link-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...verlay.test.ts-snapshots/image-overlay-modal-dark-mode-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t.ts-snapshots/image-overlay-modal-dark-mode-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...st.ts-snapshots/image-overlay-modal-dark-mode-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...erlay.test.ts-snapshots/image-overlay-modal-light-mode-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....ts-snapshots/image-overlay-modal-light-mode-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t.ts-snapshots/image-overlay-modal-light-mode-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...geOverlay.test.ts-snapshots/image-overlay-loaded-stage-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...test.ts-snapshots/image-overlay-loaded-stage-Mobile-Android-Landscape-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....test.ts-snapshots/image-overlay-loaded-stage-Mobile-Android-Portrait-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...eOverlay.test.ts-snapshots/image-overlay-loading-stage-Desktop-Chrome-linux.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...est.ts-snapshots/image-overlay-loading-stage-Mobile-Android-Landscape-linux.png
View file
Binary file modified ...test.ts-snapshots/image-overlay-loading-stage-Mobile-Android-Portrait-linux.png
View file
Binary file modified ...tic/ImageOverlay.test.ts-snapshots/image-overlay-modal-Desktop-Chrome-linux.png
View file
Binary file modified ...verlay.test.ts-snapshots/image-overlay-modal-Mobile-Android-Landscape-linux.png
View file
Binary file modified ...Overlay.test.ts-snapshots/image-overlay-modal-Mobile-Android-Portrait-linux.png
View file
Binary file modified ...rlay.test.ts-snapshots/image-overlay-modal-broken-link-Desktop-Chrome-linux.png
View file
Binary file modified ...ts-snapshots/image-overlay-modal-broken-link-Mobile-Android-Landscape-linux.png
View file
Binary file modified ....ts-snapshots/image-overlay-modal-broken-link-Mobile-Android-Portrait-linux.png
View file
Binary file modified ...verlay.test.ts-snapshots/image-overlay-modal-dark-mode-Desktop-Chrome-linux.png
View file
Binary file modified ...t.ts-snapshots/image-overlay-modal-dark-mode-Mobile-Android-Landscape-linux.png
View file
Binary file modified ...st.ts-snapshots/image-overlay-modal-dark-mode-Mobile-Android-Portrait-linux.png
View file
Binary file modified ...erlay.test.ts-snapshots/image-overlay-modal-light-mode-Desktop-Chrome-linux.png
View file
Binary file modified ....ts-snapshots/image-overlay-modal-light-mode-Mobile-Android-Landscape-linux.png
View file
Binary file modified ...t.ts-snapshots/image-overlay-modal-light-mode-Mobile-Android-Portrait-linux.png
View file
Binary file modified ...ositeJavascriptTest.test.ts-snapshots/chatCompositeHtmlCheck-chromium-linux.png
View file

0 comments on commit 964ac5f

Please sign in to comment.