Sync SiegeEvent fields/props #1027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettluskey
requested changes
Nov 9, 2024
|
|
||
| Assert.True(client.ObjectManager.TryGetObject<BesiegerCamp>(besiegerCampId, out var clientBesiegerCamp)); | ||
|
|
||
| Assert.True(clientBesiegerCamp == SiegeEvent.BesiegerCamp); |
There was a problem hiding this comment.
Suggested change
| Assert.True(clientBesiegerCamp == SiegeEvent.BesiegerCamp); | |
| Assert.Same(clientBesiegerCamp == SiegeEvent.BesiegerCamp); |
|
|
||
| Assert.True(client.ObjectManager.TryGetObject<Settlement>(besiegedSettlementId, out var clientBesiegedSettlement)); | ||
|
|
||
| Assert.True(clientBesiegedSettlement == SiegeEvent.BesiegedSettlement); |
There was a problem hiding this comment.
Suggested change
| Assert.True(clientBesiegedSettlement == SiegeEvent.BesiegedSettlement); | |
| Assert.Same(clientBesiegedSettlement == SiegeEvent.BesiegedSettlement); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SiegeEvent fields and props not synced
What is the new behavior?
Resolves #917
Resolves #916
Syncs Fields: BesiegedSettlement, BesiegerCamp, _isBesiegerDefeated
Syncs Props: SiegeStartTime
Adds E2E
Other information
The first commit was made entirely by running
coop-create all "TaleWorlds.CampaignSystem.Siege.SiegeEvent, TaleWorlds.CampaignSystem" --members BesiegedSettlement BesiegerCamp _isBesiegerDefeated SiegeStartTimeThis PR is also a proof of concept for the new scaffolding CLI, by reviewing it you are also reviewing the CLI's template files.