-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement New Plugin Architecture and Prepare for 0.4.0 Release #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd polish the code style
- missing config initiation at project root - several minor tonifti app related bug fix included - version upgrade to 0.4.0 upon new feature
- Enable SnippetsFetcher to automatically search for remote content upon invocation. - Add the first version of docstrings throughout the module to improve code documentation.
- Revise and enhance docstrings throughout the module to improve code documentation and readability. - Add detailed descriptions for class methods and properties, focusing on parameters and behaviors.
…tence - Integrate `PathResolver` as a parent class across the `__init__.py` and `study.py` modules to standardize and normalize all path operations using `_resolve(path)`. - Fix a critical bug in `study.py` where study information was lost after execution. Now, study info persists correctly, enhancing data reliability for MRI scans and raw dataset sessions. - Ensure consistent and accurate path handling and data retention across the module.
…ndition - Correct the misplaced type annotation that caused a 'type not found' error when the TYPE_CHECKING condition was active. - Ensure type annotations are correctly placed and accessible, preventing runtime errors in the parameters module.
- Enhanced docstrings in `PvStudy`, `PvScan`, `PvReco`, and `PvFiles` classes for better clarity and consistency. - Improved method descriptions, parameter details, and added examples where missing.
- work in progress, unstable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110 #127 #132 #135 #146 #155
Changes Proposed in This Pull Request:
tonifti
app can now integrate reconstruction middleware.@BrkRaw/brkraw