Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree data new BUGFIX correctly mark lyd_new_term_bin definition #2297

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

gotthardp
Copy link
Contributor

The lyd_new_term_bin is declared as an API function using LIBYANG_API_DECL.
Its definition however also uses LIBYANG_API_DECL, whereas I believe it should use LIBYANG_API_DEF like all the other functions.

/** Exporting symbols to a shared library and importing back afterwards
 *
 * - use LIBYANG_API_DECL to mark a declaration in the public header
 * - use LIBYANG_API_DEF to mark a definition (in the source code for the actual implementaiton)
 * */

@michalvasko michalvasko merged commit 17002f0 into CESNET:devel Sep 9, 2024
13 checks passed
@michalvasko
Copy link
Member

Right, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants