-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: added taxonomy pages to sitemap #49
base: main
Are you sure you want to change the base?
WIP: added taxonomy pages to sitemap #49
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For whatever reason the postType post.has_archive === false not sure why this might be |
Is this happening just for the nextwordpress.wpengine.com used in the starter example, or for all WP sites? |
Also, you should review the If I remember correctly, I think for any post type that is enabled, we are just getting all taxonomies that are used on that post type, not just getting all taxonomies for everything. |
Thanks for the tip! I'll take a look and see if I can reduce the complexity |
ill test this |
…-&-archive-pagination-enhancement
it's woooooooooooooorking!!!!! i don't know |
It would be great if we could write a test for generateStaticParams and generateSitemap and make sure these are always generating the same page urls. |
YEAH! I was also thinking that considering it's starting to get more complex, what would you recommend for testing? |
@@ -29,10 +33,59 @@ export async function getAllItems(postTypes: string[]): Promise<Items> { | |||
}); | |||
|
|||
let result: Items = []; | |||
const archiveParams = await getArchiveStaticParams({ postTypes }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you added this to getAllItems
, getAllItems
just gets all single items from specified post types so this would be the wrong place to add this!
Just seeing if it breaks or not here:
Still need to add pagination
Example
/blog/
/blog/1 ?
/blog/2