Test throttle rates #1679
Draft
Test throttle rates #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last point was indeed due to the cache from the first registration test. |
lukavdplas
reviewed
Oct 21, 2024
| @@ -46,3 +52,44 @@ def test_register_verification(client, db, django_user_model): | |||
| assert allauth_email.email == creds.get('email') | |||
| assert allauth_email.verified is True | |||
| assert allauth_email.primary is True | |||
|
|
|||
|
|
|||
| def test_register_throttling(client, throttle_settings): | |||
There was a problem hiding this comment.
The throttle rate from the fixture is not actually applied, although its value is read correctly in the test function
Perhaps an obvious suggestion, but did you try this?
Suggested change
| def test_register_throttling(client, throttle_settings): | |
| def test_register_throttling(throttle_settings, client): |
There was a problem hiding this comment.
I've now tried this, but the result is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP, some things to resolve here still:
The throttle rate from the fixture is not actually applied, although its value is read correctly in the test function (same for
@override_settings). The settings that are actually used are the defaults fromcommon_settings.py.I thought I might have to use the
rest_framework.test APIClientfor this, but it seems to behave the same whether I use the defaultclientordrf_clientI added here.cache issue
In addition, this is strange: when I test manually with `'registration': '1/minute'`, the first registration succeeds and the second one gets a 429, as expected. But with the default rate of `'registration': '5/minute'` that is (apparently?) picked up by pytest, we get this:I would've expected Request 5 to still succeed. Caching issue?