Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for schema changes in cesium-native #1552

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void FCesiumPropertyTableSpec::Define() {
model = CesiumGltf::Model();
pExtension =
&model.addExtension<CesiumGltf::ExtensionModelExtStructuralMetadata>();
pExtension->schema = CesiumGltf::Schema();
pExtension->schema.emplace();
pPropertyTable = &pExtension->propertyTables.emplace_back();
});

Expand All @@ -42,7 +42,7 @@ void FCesiumPropertyTableSpec::Define() {
});

It("constructs invalid instance for missing schema", [this]() {
pExtension->schema = std::nullopt;
pExtension->schema.reset();

FCesiumPropertyTable propertyTable(model, *pPropertyTable);
TestEqual(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void FCesiumPropertyTextureSpec::Define() {
BeforeEach([this]() {
model = Model();
pExtension = &model.addExtension<ExtensionModelExtStructuralMetadata>();
pExtension->schema = Schema();
pExtension->schema.emplace();
pPropertyTexture = &pExtension->propertyTextures.emplace_back();
});

Expand All @@ -53,7 +53,7 @@ void FCesiumPropertyTextureSpec::Define() {
});

It("constructs invalid instance for missing schema", [this]() {
pExtension->schema = std::nullopt;
pExtension->schema.reset();

FCesiumPropertyTexture propertyTexture(model, *pPropertyTexture);
TestEqual(
Expand Down
2 changes: 1 addition & 1 deletion extern/cesium-native
Submodule cesium-native updated 130 files
Loading