Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(f3): suppress INFO logs under f3 to reduce noises #4942

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix(f3): suppress INFO logs under f3 to reduce noises #4942

merged 2 commits into from
Oct 28, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 28, 2024 •
edited
Loading

Summary of changes

This PR sets f3 log level to WARN to suppress noises. We could change it back to INFO if filecoin-project/go-f3#724 is accepted and released.

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 28, 2024 13:49
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 28, 2024 13:49
@hanabi1224 hanabi1224 requested review from ruseinov and elmattic and removed request for a team October 28, 2024 13:49
@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 3497d5e Oct 28, 2024
39 checks passed
@hanabi1224 hanabi1224 deleted the hm/f3-log-level branch October 28, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmattic elmattic elmattic approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @LesnyRumcajs @elmattic