Don't initialize youtube resolver if youtube-api-key is empty #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Don't initialize youtube resolver if api key is empty. As far as I can tell from reading the source, the package we are using does not care about the api key being empty and does not return an error.
The test inintialize_test.go
fails for me locally, but it passes in CI.That might be worth an investigation?Turns out
google.golang.org/api/youtube/v3
automatically pulls in creentials fromGOOGLE_APPLICATION_CREDENTIALS