Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17 Fix Start Time for Cuy Arts & Culture #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

markwryan
Copy link

@markwryan markwryan commented Mar 31, 2021

Fix Start Time for Cuyahoga County Arts & Culture Spider

Description in newer events are missing the full date & time. If not pulled from the description, attempt to pull from the heading in the page which is a slightly different format ("p.m." is used instead of "pm")

Issue: #17

Checklist

All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.

  • Tests are implemented
  • All tests are passing
  • Style checks run (see documentation for more details)
  • Style checks are passing
  • Code comments from template removed

Questions

  • Existing tests pass. Happy to add one for the backup extract of date/time if needed. Saw this was marked urgent, and this is my first PR into this project, so wanted to get any other feedback as well.

…comming events for Cuyahoga County Arts and Culture. Start time removed specifying the year as well as changing am/pm to a.m. or p.m.
@skorasaurus
Copy link
Collaborator

Thanks @markwryan ; I'll try and look at this later today or tomorrow :)

@markwryan
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants