Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting HOM J #145

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Plotting HOM J #145

merged 1 commit into from
Sep 7, 2023

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Jul 12, 2023

Purpose

Including plots for homogeneous nucleation rate coefficient to verify values.

To-do

  • compare J_hom to that in Koop 2000
  • move plots to IceNucleation.md?
  • uncomment @asserts in Common.jl (H2SO4 vapor pressure)

Content

  • plot of log10(J_hom) vs T where J is in cm^-3 s^-1

  • I have read and checked the items on the review checklist.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (787345d) 96.04% compared to head (0350cf3) 96.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          16       16           
  Lines         911      911           
=======================================
  Hits          875      875           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amylu00
Copy link
Member Author

amylu00 commented Jul 12, 2023

Trying to replicate blue curve (at aqueous saturation):
homJvsT

What I have with x_sulph = 0.027 (anything higher results in Delta_a_w being out of valid range, anything lower results in shorter curve; 0.027 seems like already much lower than atmospheric conditions)
Screenshot 2023-07-12 at 12 55 02 PM

Spichtinger et al 2023 states "formulations should match in the temperature range 235 K ≤ T ≤ 240 K, since this range is relevant for the freezing of pure water cloud droplets with reasonable sizes. This temperature range at water saturation is equivalent to the range of water activity difference 0.27 < Delta_a_w < 0.31". But at those temperature bounds, I get 0.29 < Delta_a_w < 0.31. This is probably why the warmer end of my curve has log10(J) values so much higher than the paper's.

@amylu00
Copy link
Member Author

amylu00 commented Jul 12, 2023

Calculating Delta_a_w the way Koop 2000 did at x = 0.032 and constant P = 0.01 GPa gives me
Screenshot 2023-07-12 at 3 49 30 PM

But the max valid P decreases each iteration and goes into the negatives. Still can't increase x_sulph to a more reasonable mass fraction like 0.8.

@amylu00
Copy link
Member Author

amylu00 commented Jul 13, 2023

bors try

bors bot added a commit that referenced this pull request Jul 13, 2023
@bors
Copy link
Contributor

bors bot commented Jul 13, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@amylu00
Copy link
Member Author

amylu00 commented Jul 26, 2023

For all plots, blue curve is our parameterization and yellow curve are literature values. All literature values are implementations of Koop 2000.

x_sulph = 0.031 (minimum value that doesn't give NaN error)
x_0 031

x_sulph = 0.04
x_0 04

x_sulph = 0.065
x_0 065

The right-most plot is off by a factor of 8. When I force it to match Baumgartner by dividing J by 8, the other plots to the left of it don't get any better. In fact, for x = 0.065, I can see that the leftmost plot gets farther than the literature values.

@trontrytel trontrytel force-pushed the al/hom_plots branch 2 times, most recently from 059e2b2 to e3884e8 Compare August 18, 2023 18:23
@trontrytel trontrytel linked an issue Aug 23, 2023 that may be closed by this pull request
comparing plots

testing stuff out

Adding homogeneous J example plot

add new velocity types to exports

fix apparent nucleation

Add predicting properties from the p3 scheme

Move ice nucleation J params to CLIMAParams

Fix package deps for a release

adding area docs

Update to julia 1.9.2

Simplify Microphysics0M

Fix nucleation parameter flow, const statements

Add project to test path

Update to new thermodynamics

bump version down

Add KA13 J vs T plots

Restructure CloudMicrophysics 0M code

bump down julia compat req.

fix broadcasting issue for ClimaAtmos

Update P3 scheme to new parameters, cleanup code and docs plots

Add additional constructors for CloudMicrophysicsParameters0M and CloudMicrophysicsParametersP3

introduce water water_activity

typo?

documentation + moving plot file to folder

duplicate in bibliography

Add aqua tests, small fixes for tests

untangling water activity from abifm docs

fix plot
@amylu00
Copy link
Member Author

amylu00 commented Sep 7, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 7, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit b742e39 into main Sep 7, 2023
8 checks passed
@bors bors bot deleted the al/hom_plots branch September 7, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameterization of homogeneous freezing
2 participants