Implementing Chen 2022 Formulas (rain, ice, snow) into 1M scheme #149

apoorva-thanvantri · 2023-07-28T22:28:16Z

Purpose

Implementing formulas from Chen 2022 into the 1M scheme

To-do

Content

formulas
documentation
unit tests

I have read and checked the items on the review checklist.

codecov · 2023-07-28T22:39:24Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (abec798) 97.67% compared to head (9c32355) 97.68%.

❗ Current head 9c32355 differs from pull request most recent head 49e3f7d. Consider uploading reports for the commit 49e3f7d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   97.67%   97.68%   +0.01%     
==========================================
  Files          12       12              
  Lines         818      822       +4     
==========================================
+ Hits          799      803       +4     
  Misses         19       19

Files Changed	Coverage Δ
src/Common.jl	`100.00% <100.00%> (ø)`
src/CommonTypes.jl	`80.00% <100.00%> (+2.22%)`	⬆️
src/Microphysics1M.jl	`100.00% <100.00%> (ø)`
src/Microphysics2M.jl	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trontrytel · 2023-08-11T00:45:07Z

@apoorva-thanvantri - Thank you for adding all the parameterizations to the 1-moment scheme. It's really cool that you added the aspect ratio computation for snow!

I squashed and rebased everything and modified the velocity comparison plots and the documentation. I think that to avoid conflicts the easiest thing would be to delete or rename your old branch. And then checkout to a new branch from main and pull the changes. Otherwise you will be resolving many conflicts.

A couple of things to do before we can merge this:

I think the test for ice terminal velocity was wrong before. Because it was using the snow size distribution parameters when computing lambda for ice. Let me know if you agree. If yes, then we should fix the test.
Where are the hardcoded numbers in tests come from?
Would be great to add a plot of how the snow aspect ratio depends on the size
Would be great to also add a plot of individual terminal velocity for ice particles
We should move the free parameters to CLIMAParameters. Similar to what I did for the 2-moment rain PR.
Let me know if you could take those on. Also, please take a look at the documentation page and see if you agree with the changes there!

~~I'll think some more on how to refactor the 1-moment terminal velocity functions such that we could keep the function signature the same and just dispatch based on the particle and scheme type.~~ - Done!

trontrytel · 2023-08-11T00:50:22Z

See also issue #154 To fully update the bulk 1-moment scheme to Chen et al 2022 velocities we would also have to re-do the integrals such as accretion, evaporation and such. Maybe we should meet for some integral party at some point. Those are not hard, but it will be annoying (especially for snow...)

amylu00

It looks beautiful, you did great Apoorva! A lot of my suggestions are just changing some whole numbers to FT(number) just to keep things consistent, not sure if there's any value in that computationally, but just in case? My other suggestions are related to the valid range of D_r. I think these changes would make it easier on future users/developers because it's so easy to be unaware that you're out of the valid range.

amylu00 · 2023-08-11T05:31:20Z

docs/src/Microphysics1M.md

+The rain ``a_i``, ``b_i``, and ``c_i`` are listed in the table below.
+The formula is applicable when ``D > 0.1 mm``,
+$q$ refers to ``q = e^{0.115231 \; \rho_a}``, where  ``\rho_a`` is air density [kg/m3].
+The units are: [v] = m/s, [D]=mm, [``a_i``] = ``mm^{-b_i} m/s``, [``b_i``] is dimensionless, [``c_i``] = 1/mm.


It looks like in the actual code, D [=] meters. Maybe note that here so that the user doesn't get confused with units when using the code.

amylu00 · 2023-08-11T05:33:04Z

docs/src/Microphysics1M.md

+The rain ``a_i``, ``b_i``, and ``c_i`` are listed in the table below.
+The formula is applicable when ``D > 0.1 mm``,
+$q$ refers to ``q = e^{0.115231 \; \rho_a}``, where  ``\rho_a`` is air density [kg/m3].
+The units are: [v] = m/s, [D]=mm, [``a_i``] = ``mm^{-b_i} m/s``, [``b_i``] is dimensionless, [``c_i``] = 1/mm.


Suggested change

The units are: [v] = m/s, [D]=mm, [``a_i``] = ``mm^{-b_i} m/s``, [``b_i``] is dimensionless, [``c_i``] = 1/mm.

The units are: [v] = m/s, [D] = mm, [``a_i``] = ``mm^{-b_i} m/s``, [``b_i``] is dimensionless, [``c_i``] = 1/mm.

amylu00 · 2023-08-11T05:37:55Z

docs/src/TerminalVelocityComparisons.jl

+        ((16 * (a0_comb)^3 * (ρ_i)^2) / (9 * π * (m0_comb)^2)) *
+        (D_r / (2 * _r0 * 1000))^(3 * ae_comb - 2 * me_comb)
+    aspect_ratio = aspect_ratio^(α)
+    vt = 0


Suggested change

vt = 0

vt = FT(0)

amylu00 · 2023-08-11T05:39:44Z

src/Microphysics1M.jl

+        k = 3 #for mass weighted terminal velocity
+
+        if precip isa CT.RainType && spherical
+            ϕ = 1


Suggested change

ϕ = 1

ϕ = FT(1)

Definitely! Otherwise it's not type stable. I'll try to refactor the code a little to have the same function signature for all 1-moment terminal velocities. I can change all of those

src/Microphysics1M.jl

docs/src/TerminalVelocityComparisons.jl

src/Microphysics1M.jl

apoorva-thanvantri · 2023-08-11T18:04:59Z

Hi! Sounds good - I'm running a few more simulations on KiD and then I will get to these issues (I can add the plots and move the parameters). I'm also free for an integral party whenever :)

…

On Fri, Aug 11, 2023 at 10:21 AM Anna Jaruga ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Microphysics1M.jl <#149 (comment)> : > + + As = 0.00174079 * (log(ρ_i))^2 − 0.0378769 * log(ρ_i) - 0.263503 + Bs = (0.575231 + 0.0909307 * log(ρ_i) + 0.515579 / sqrt(ρ_i))^(-1) + Cs = + -0.345387 + + 0.177362 * exp(-0.000427794 * ρ_i) + + 0.00419647 * sqrt(ρ_i) + Es = -0.156593 - 0.0189334 * (log(ρ_i))^2 + 0.1377817 * sqrt(ρ_i) + Fs = -exp(-3.35641 - 0.0156199 * (log(ρ_i))^2 + 0.765337 * log(ρ_i)) + Gs = + (-0.0309715 + 1.55054 / (log(ρ_i)) - 0.518349 * log(ρ_i) / ρ_i)^(-1) + + k = 3 #for mass weighted terminal velocity + + if precip isa CT.RainType && spherical + ϕ = 1 Definitely! Otherwise it's not type stable. I'll try to refactor the code a little to have the same function signature for all 1-moment terminal velocities. I can change all of those — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQD2TPTMRFK2PRPN5H2NACDXUZSZVANCNFSM6AAAAAA24BRI5M> . You are receiving this because you were assigned.Message ID: ***@***.***>

trontrytel · 2023-08-17T21:44:57Z

Closing in favour of #163

trontrytel added this to the Update terminal velocity formulae milestone Aug 9, 2023

trontrytel added the Terminal velocity label Aug 9, 2023

trontrytel force-pushed the at/terminal_velocity_1M branch 2 times, most recently from 474ce0b to 4a44974 Compare August 11, 2023 00:36

trontrytel assigned trontrytel and apoorva-thanvantri Aug 11, 2023

trontrytel requested review from trontrytel, edejong-caltech and amylu00 August 11, 2023 00:47

amylu00 reviewed Aug 11, 2023

View reviewed changes

Add Chen et al 2022 terminal velocities to 1-moment scheme

49e3f7d

trontrytel force-pushed the at/terminal_velocity_1M branch from 9c32355 to 49e3f7d Compare August 13, 2023 22:35

trontrytel closed this Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing Chen 2022 Formulas (rain, ice, snow) into 1M scheme #149

Implementing Chen 2022 Formulas (rain, ice, snow) into 1M scheme #149

apoorva-thanvantri commented Jul 28, 2023 •

edited

Loading

codecov bot commented Jul 28, 2023 •

edited

Loading

trontrytel commented Aug 11, 2023 •

edited

Loading

trontrytel commented Aug 11, 2023 •

edited

Loading

amylu00 left a comment

amylu00 Aug 11, 2023

amylu00 Aug 11, 2023

amylu00 Aug 11, 2023

amylu00 Aug 11, 2023

trontrytel Aug 11, 2023

apoorva-thanvantri commented Aug 11, 2023 via email

trontrytel commented Aug 17, 2023

	The units are: [v] = m/s, [D]=mm, [``a_i``] = ``mm^{-b_i} m/s``, [``b_i``] is dimensionless, [``c_i``] = 1/mm.
	The units are: [v] = m/s, [D] = mm, [``a_i``] = ``mm^{-b_i} m/s``, [``b_i``] is dimensionless, [``c_i``] = 1/mm.

Implementing Chen 2022 Formulas (rain, ice, snow) into 1M scheme #149

Implementing Chen 2022 Formulas (rain, ice, snow) into 1M scheme #149

Conversation

apoorva-thanvantri commented Jul 28, 2023 • edited Loading

Purpose

To-do

Content

codecov bot commented Jul 28, 2023 • edited Loading

Codecov Report

trontrytel commented Aug 11, 2023 • edited Loading

trontrytel commented Aug 11, 2023 • edited Loading

amylu00 left a comment

Choose a reason for hiding this comment

amylu00 Aug 11, 2023

Choose a reason for hiding this comment

amylu00 Aug 11, 2023

Choose a reason for hiding this comment

amylu00 Aug 11, 2023

Choose a reason for hiding this comment

amylu00 Aug 11, 2023

Choose a reason for hiding this comment

trontrytel Aug 11, 2023

Choose a reason for hiding this comment

apoorva-thanvantri commented Aug 11, 2023 via email

trontrytel commented Aug 17, 2023

apoorva-thanvantri commented Jul 28, 2023 •

edited

Loading

codecov bot commented Jul 28, 2023 •

edited

Loading

trontrytel commented Aug 11, 2023 •

edited

Loading

trontrytel commented Aug 11, 2023 •

edited

Loading