Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ice nucleation J params to CLIMAParams #170

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Move ice nucleation J params to CLIMAParams #170

merged 1 commit into from
Aug 22, 2023

Conversation

trontrytel
Copy link
Member

@trontrytel trontrytel commented Aug 18, 2023 •
edited
Loading

This PR:

  • moves ice nucleation parameters to CLIMAParameters
  • specifies CLIMAParameters version in Compat

@trontrytel trontrytel added this to the Ice nucleation scheme milestone Aug 21, 2023
@trontrytel trontrytel self-assigned this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (3d9df6a) 98.16% compared to head (362c1e3) 98.19%.

❗ Current head 362c1e3 differs from pull request most recent head 57c4b48. Consider uploading reports for the commit 57c4b48 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   98.16%   98.19%   +0.03%     
==========================================
  Files          13       13              
  Lines         872      887      +15     
==========================================
+ Hits          856      871      +15     
  Misses         16       16
Files Changed Coverage Δ
src/Parameters.jl 53.84% <ø> (ø)
src/Common.jl 100.00% <100.00%> (ø)
src/IceNucleation.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amylu00
amylu00 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@amylu00 amylu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a change in variable name for w_h so it's consistent with Luo's paper. Thanks Anna!

src/Common.jl Outdated Show resolved Hide resolved
src/Common.jl Outdated Show resolved Hide resolved
@trontrytel trontrytel marked this pull request as ready for review August 21, 2023 23:03
@trontrytel
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 22, 2023
@bors @trontrytel
Merge #170
ba3c246 
170: Move ice nucleation J params to CLIMAParams r=trontrytel a=trontrytel

This PR:
- moves ice nucleation parameters to CLIMAParameters
- specifies CLIMAParameters version in Compat

Co-authored-by: Anna Jaruga <ajaruga@caltech.edu>
@bors
Copy link
Contributor

bors bot commented Aug 22, 2023

Build failed:

@trontrytel
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 22, 2023
@bors
Try #170:
47111c6
@bors
Copy link
Contributor

bors bot commented Aug 22, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@trontrytel
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 1e82cac into main Aug 22, 2023
8 checks passed
@bors bors bot deleted the aj/ice_nucleation_parameters branch August 22, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amylu00 amylu00 amylu00 approved these changes

@nefrathenrici nefrathenrici Awaiting requested review from nefrathenrici

Assignees

@trontrytel trontrytel

Labels
Ice ⛄
Projects
None yet
Milestone
O1.3.4 Ice nucleation scheme
Development

Successfully merging this pull request may close these issues.
2 participants
@trontrytel @amylu00