Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML aerosol activation emulators #172

Closed
wants to merge 5 commits into from

Conversation

mikhailmints
Copy link
Contributor

Purpose

This PR adds support for ML aerosol activation emulators to be used instead of the ARG scheme.

To-do

Fix the tests and documentation for these changes, possibly improve the abstractions used in the models to avoid hardcoding hyperparameters.

Content

  • Add support for using data-driven emulators of aerosol activation, which can be loaded through MLJ.
  • Add utilities for data preprocessing and model construction.
  • Add the free parameters of the ARG scheme to the parameter set.
  • Add PySDM data to ARG plots in documentation.

  • I have read and checked the items on the review checklist.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (0898dd4) 98.19% compared to head (e7cc4e2) 82.46%.
Report is 122 commits behind head on main.

❗ Current head e7cc4e2 differs from pull request most recent head e73b042. Consider uploading reports for the commit e73b042 to get more accurate results

Files Patch % Lines
src/PreprocessAerosolData.jl 0.00% 123 Missing ⚠️
src/ActivationEmulatorModels.jl 0.00% 35 Missing ⚠️
src/AerosolActivation.jl 47.82% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #172       +/-   ##
===========================================
- Coverage   98.19%   82.46%   -15.73%     
===========================================
  Files          13       15        +2     
  Lines         887     1061      +174     
===========================================
+ Hits          871      875        +4     
- Misses         16      186      +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trontrytel
Copy link
Member

Done in #349 and #318

@trontrytel trontrytel closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NN aerosol activation parameterizations extension to CloudMicrophysics
2 participants