Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Microphysics0M #194

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Simplify Microphysics0M #194

merged 1 commit into from
Aug 29, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Aug 29, 2023 •
edited
Loading

Simplify Microphysics0M

  • I have read and checked the items on the review checklist.

@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 29, 2023
@bors
Try #194:
7de97fd
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (82675d9) 98.31% compared to head (5bd077f) 98.29%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files          14       14              
  Lines         888      882       -6     
==========================================
- Hits          873      867       -6     
  Misses         15       15
Files Changed Coverage Δ
src/Microphysics0M.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bors
Copy link
Contributor

bors bot commented Aug 29, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@sriharshakandala sriharshakandala marked this pull request as ready for review August 29, 2023 17:51
@sriharshakandala
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 29, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit fa206ba into main Aug 29, 2023
8 checks passed
@bors bors bot deleted the sk/simplify branch August 29, 2023 19:12
@trontrytel trontrytel mentioned this pull request Aug 29, 2023
Merged
@sriharshakandala sriharshakandala linked an issue Aug 31, 2023 that may be closed by this pull request
GPU check Microphysics0M #199
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU check Microphysics0M
2 participants
@sriharshakandala @trontrytel