Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Water Activity Documentation/Plots #203

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Water Activity Documentation/Plots #203

merged 1 commit into from
Sep 6, 2023

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Aug 31, 2023

Purpose

Add detailed documentation for water activity.

To-do

  • add plot of various vapor pressure parameterizations
  • add plot of various T vs a_w's parameterizations
  • explain the different parameterizations
  • explain what happens when droplets are equilibrium with environment
  • explain why sometimes dew point is needed
  • add note about needing a parameterization for solution droplets at T > 235K

Content

  • I have read and checked the items on the review checklist.

@amylu00 amylu00 self-assigned this Aug 31, 2023
@amylu00 amylu00 added documentation Improvements or additions to documentation Ice ⛄ labels Aug 31, 2023
@amylu00 amylu00 added this to the O1.3.4 Ice nucleation scheme milestone Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (41b3050) 96.23% compared to head (6a30f8c) 96.23%.

❗ Current head 6a30f8c differs from pull request most recent head 247b119. Consider uploading reports for the commit 247b119 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files          16       16           
  Lines         903      903           
=======================================
  Hits          869      869           
  Misses         34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trontrytel trontrytel linked an issue Sep 1, 2023 that may be closed by this pull request
Homogeneous Freezing Δa_w Parameterization #137
Closed
@trontrytel trontrytel self-requested a review September 6, 2023 04:05
trontrytel
trontrytel approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for persisting and figuring it all out.

@trontrytel
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit efe35c3 into main Sep 6, 2023
6 checks passed
@bors bors bot deleted the al/water_activity branch September 6, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

Assignees

@amylu00 amylu00

Labels
documentation Improvements or additions to documentation Ice ⛄
Projects
None yet
Milestone
O1.3.4 Ice nucleation scheme
Development

Successfully merging this pull request may close these issues.

Homogeneous Freezing Δa_w Parameterization
2 participants
@amylu00 @trontrytel