Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aqua tests, small fixes for tests #208

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Add aqua tests, small fixes for tests #208

merged 1 commit into from
Sep 6, 2023

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Sep 5, 2023 •
edited
Loading

Content:

  • Add aqua and tests. There currently four function signatures with unbound args due to a known issue with aqua.
  • Remove exports for variables that no longer exist: ABIFM_Delta_a_w and Chen_snow_ice_coeffs

@nefrathenrici
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 5, 2023
@bors @nefrathenrici
Merge #208
738c42f 
208: Add aqua tests, small fixes for tests r=nefrathenrici a=nefrathenrici

Content:
- Add aqua and tests. There currently four function signatures with unbound args due to a known issue with aqua.
- Remove exports for variables that no longer exist: `ABIFM_Delta_a_w` and `Chen_snow_ice_coeffs`


Co-authored-by: nefrathenrici <nat.henrici@gmail.com>
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (efe35c3) 96.04% compared to head (ffa733b) 96.04%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          16       16           
  Lines         911      911           
=======================================
  Hits          875      875           
  Misses         36       36
Files Changed Coverage Δ
src/Common.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bors
Copy link
Contributor

bors bot commented Sep 5, 2023

Build failed:

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 6, 2023
@bors
Try #208:
1d16d4c
@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

try

Build failed:

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 6, 2023
@bors
Try #208:
decb0ac
@nefrathenrici
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

try

Already running a review

@nefrathenrici
Copy link
Member Author

bors try-

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 6, 2023
@bors
Try #208:
2be553e
@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

try

Build failed:

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 6, 2023
@bors
Try #208:
4e541db
charleskawczynski
charleskawczynski reviewed Sep 6, 2023
View reviewed changes
test/aqua.jl Outdated Show resolved Hide resolved
charleskawczynski
charleskawczynski reviewed Sep 6, 2023
View reviewed changes
test/aqua.jl Outdated Show resolved Hide resolved
@nefrathenrici
Copy link
Member Author

bors try-

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 6, 2023
@bors
Try #208:
924ae3d
@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

try

Build failed:

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 6, 2023
@bors
Try #208:
e940564
@nefrathenrici
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors
Copy link
Contributor

bors bot commented Sep 6, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f1e2b0d into main Sep 6, 2023
8 checks passed
@bors bors bot deleted the ne/aqua branch September 6, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@trontrytel trontrytel Awaiting requested review from trontrytel

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nefrathenrici @charleskawczynski @trontrytel