breakup the P3 scheme file #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 37 41 +4
Lines 1464 1465 +1
=======================================
+ Hits 1420 1421 +1
Misses 44 44
|
trontrytel
force-pushed
the
aj/p3_remodel
branch
from
8bfc889
to
df079ef
Compare
trontrytel
force-pushed
the
aj/p3_remodel
branch
from
df079ef
to
9cf787d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not add any new code. It only breaks the
P3Scheme.jlfile into a couple of smaller files to help with the readability. We will now have:P3.jl- defines the module and includes all the other filesP3_helpers.jl- helpers for special functions and integralsP3_particle_properties.jl- thresholds solver and anything related to different size regimesP3_size_distribution.jl- size distribution solver and anything related to itP3_terminal_velocity.jl- mass weighted and number weighted Chen2022 terminal velocity calculated over all size regimesP3_processes.jl- placeholder to add all the processes (collisions, melting etc)