Add cloud condensate sedimentation velocity #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 96.95% 96.98% +0.03%
==========================================
Files 41 41
Lines 1543 1559 +16
==========================================
+ Hits 1496 1512 +16
Misses 47 47
|
tapios
approved these changes
Oct 5, 2024
src/Microphysics1M.jl
Outdated
| @@ -187,37 +185,31 @@ function terminal_velocity( | |||
| q::FT, | |||
| ) where {FT} | |||
| fall_w = FT(0) | |||
| # For now we assume B4 table coefficiantes for snow | |||
There was a problem hiding this comment.
Suggested change
| # For now we assume B4 table coefficiantes for snow | |
| # For now, we assume the B4 table coefficients for snow |
src/Microphysics1M.jl
Outdated
| @@ -187,37 +185,31 @@ function terminal_velocity( | |||
| q::FT, | |||
| ) where {FT} | |||
| fall_w = FT(0) | |||
| # For now we assume B4 table coefficiantes for snow | |||
| # and B2 table coefficients for cloud ice. | |||
| # TODO - we should do an integral by parts | |||
There was a problem hiding this comment.
Suggested change
| # TODO - we should do an integral by parts | |
| # TODO - we should do partial integrals |
src/Microphysics1M.jl
Outdated
| a0c = a0 * χa | ||
| mec = me + Δm | ||
| aec = ae + Δa | ||
| # As a next step could keep ϕ(r) under the integrals |
There was a problem hiding this comment.
Suggested change
| # As a next step could keep ϕ(r) under the integrals | |
| # As a next step, we could keep ϕ(r) under the integrals |
src/MicrophysicsNonEq.jl
Outdated
|
|
||
| Returns the mass weighted average terminal velocity assuming a | ||
| monodisperse size distribution with prescribed number concentration. | ||
| Fall velocity of individual particles is parameterized following |
There was a problem hiding this comment.
Suggested change
| Fall velocity of individual particles is parameterized following | |
| The fall velocity of individual particles is parameterized following |
src/MicrophysicsNonEq.jl
Outdated
| # that is more suited for cloud droplets. For now I'm just multiplying | ||
| # by an arbitrary correction factor. | ||
| aiu, bi, ciu = CO.Chen2022_vel_coeffs_B1(vel, ρ) | ||
| # The 1-m scheme does not assume any cloud droplet size distribution. |
There was a problem hiding this comment.
Suggested change
| # The 1-m scheme does not assume any cloud droplet size distribution. | |
| # The 1M scheme does not assume any cloud droplet size distribution. |
Co-authored-by: Tapio Schneider <tapio@caltech.edu>
trontrytel
force-pushed
the
aj/cloud_sedimentation
branch
from
5f6914f
to
06e1a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: