Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change supersaturation definition #154

Closed
trontrytel opened this issue Sep 1, 2023 · 2 comments · Fixed by #165
Closed

Change supersaturation definition #154

trontrytel opened this issue Sep 1, 2023 · 2 comments · Fixed by #165
Assignees
Labels
question Further information is requested

Comments

@trontrytel
Copy link
Member

I would like to change our supersaturation definition. What we currently have is: S = q_vap / q_sat - 1

S is typically defined as a ratio of partial pressures p_vap / p_vap_sat - 1. The outcome will be close, but not exactly the same.

It should not affect the Thermodynamics package because we don't use S to compute anything internally. But I would like to use it in CloudMicrophysics in some of the ice nucleation parameterizations

cc: @tapios, @amylu00, @szy21

@trontrytel trontrytel added the question Further information is requested label Sep 1, 2023
@trontrytel trontrytel self-assigned this Sep 1, 2023
@szy21
Copy link
Member

szy21 commented Sep 2, 2023

Sounds good, I didn't know these two are different...

@tapios
Copy link
Contributor

tapios commented Sep 2, 2023

Sounds good to me.

@trontrytel trontrytel linked a pull request Sep 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants