Change supersaturation definition #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 93.45% 93.43% -0.02%
==========================================
Files 9 9
Lines 1130 1128 -2
==========================================
- Hits 1056 1054 -2
Misses 74 74
☔ View full report in Codecov by Sentry. |
trontrytel
force-pushed
the
aj/supersat
branch
from
5e5eca7
to
6777935
Compare
trontrytel
force-pushed
the
aj/supersat
branch
from
6777935
to
5920185
Compare
charleskawczynski
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It actually shouldn't change anything right now. But i still think it will simplify life for us in CloudMicrophysics. -
Sis typically defined asp_vap / p_vap_sat. Different papers provide different parameterizations forp_vap_satand it would be good to test their impact on S and ice formation without having to go through recomputing it toq_vap_sat