Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly declare InterpolateC2F kwargs #1358

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Explicitly declare InterpolateC2F kwargs #1358

merged 1 commit into from
Oct 19, 2023

Conversation

costachris
Copy link
Member

Explicitly declare InterpolateC2F kwargs for bottom and top boundaries on area.

szy21
szy21 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just define a const operator with the correct boundary conditions and use that, like what we did here in ClimaAtmos.

@costachris
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e7c0a4f into main Oct 19, 2023
9 of 12 checks passed
@bors bors bot deleted the i2c_interp_bc branch October 19, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

@trontrytel trontrytel Awaiting requested review from trontrytel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@costachris @szy21