Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1/s entr/detr dim scales with total entr rate option #1388

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

costachris
Copy link
Member

@costachris costachris commented Feb 21, 2024

This PR:

  • Adds option to use [1/s] entrainment rate, rather than fractional rate [1/m]
    Fractional Rate -> E = $\rho a w \epsilon$ = $\rho a w (\gamma_m F)$;where $\epsilon$ is the fractional rate, $\gamma_m$ is a dimensional scale [1/m], F is a nondimensional function
    Total Rate -> E = $\rho a \gamma_s F$; where $\gamma_s$ is a dimensional scale [1/s].
  • More consistently applies min area clipping
  • Computes massflux gradient before use in entr/detr functions.

@costachris costachris force-pushed the inv_s_entr branch 7 times, most recently from 9944e7f to 65f3c47 Compare March 8, 2024 07:14
@costachris costachris force-pushed the inv_s_entr branch 2 times, most recently from cb9d724 to e6b6160 Compare March 15, 2024 00:31
src/EDMF_functions.jl Show resolved Hide resolved
src/update_aux.jl Show resolved Hide resolved
@costachris costachris changed the title Add 1/s entr/detr dim scales with total entr rate option. Change mf grad Add 1/s entr/detr dim scales with total entr rate option Mar 22, 2024
@costachris costachris merged commit f6da54f into main Mar 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants