-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(SNAP): change TransactionStateManager
to support the search of multiple transaction calls
#347
Draft
stanleyyconsensys
wants to merge
19
commits into
main
Choose a base branch
from
chore/state-mgr-support-multiple-tx-calls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor(SNAP): change TransactionStateManager
to support the search of multiple transaction calls
#347
stanleyyconsensys
wants to merge
19
commits into
main
from
chore/state-mgr-support-multiple-tx-calls
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
jonesho
and removed request for
a team
September 5, 2024 05:25
stanleyyconsensys
changed the title
refactor: change tx state manager to support multiple tx calls
refactor: change Sep 5, 2024
TransactionStateManager
to support the search of multiple transaction calls
…t-multiple-tx-calls
…t-multiple-tx-calls
…t-multiple-tx-calls
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
stanleyyconsensys
changed the title
refactor: change
refactor(SNAP): change Oct 22, 2024
TransactionStateManager
to support the search of multiple transaction callsTransactionStateManager
to support the search of multiple transaction calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to having multi calls search support in
TransactionStateManager
, hence to fit to the response fromStarkScanClient
it includes:
Requirement:
Requires this PR to be merged first:
StarkScan
client to fetch transaction history #341