Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace rpc dialogs with jsx #422

Open
wants to merge 2 commits into
base: feat/snap-fee-token-selection
Choose a base branch
from

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 requested a review from a team as a code owner November 17, 2024 22:19
@khanti42 khanti42 requested review from Julink-eth and stanleyyconsensys and removed request for a team November 17, 2024 22:19
@khanti42 khanti42 marked this pull request as draft November 18, 2024 20:48
@khanti42 khanti42 force-pushed the feat/sf-707-replace-rpc-dialogs-with-jsx branch from 44d4962 to 95485b4 Compare November 19, 2024 16:13
@khanti42 khanti42 force-pushed the feat/sf-707-replace-rpc-dialogs-with-jsx branch from 95485b4 to 9c78359 Compare November 19, 2024 16:15
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 marked this pull request as ready for review November 19, 2024 19:23
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember we discussed we create a component for each UI
and create function for those UI to render
so that the org file doesnt need to change to tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants