Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icon support in preloaded erc20 tokens #425

Draft
wants to merge 1 commit into
base: feat/sf-714-event-handler-for-fee-selection
Choose a base branch
from

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Nov 18, 2024

Description

This PR adds svg icon for the preloaded token. It also adds an icon name field in the erc20 token in state. This will be used to show Token logo in the snap interface.

Requirements

@khanti42 khanti42 requested a review from a team as a code owner November 18, 2024 20:06
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team November 18, 2024 20:06
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 changed the title feat: add icon support in default erc20 tokens feat: add icon support in preloaded erc20 tokens Nov 18, 2024
@khanti42 khanti42 marked this pull request as draft November 18, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant