Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bot settings if team member filtering #1743

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Oct 20, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at b2cf226

The pull request adds a settings prop to the SavedViewForm and its dynamic settings components to improve the saved views functionality for members. It also implements a conditional logic for the MemberBotSetting component to disable or reset the bot contacts visibility option based on the team member filter.

🤖 Generated by Copilot at b2cf226

Settings of doom, control your fate
Component of power, react and create
MemberBotSetting, disable the spy
Form.settings, save your view or die

Why

How

🤖 Generated by Copilot at b2cf226

  • Disable and clear bot contacts visibility option when team member filter is applied (link, link)
  • Pass settings prop to MemberBotSetting component in SavedViewForm (link)
  • Add disabled prop to el-radio-group in MemberBotSetting that depends on settings?.teamMember (link)
  • Update props definition, value computed property, and add watch effect in MemberBotSetting to handle settings.teamMember changes (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Oct 20, 2023
@gaspergrom gaspergrom self-assigned this Oct 20, 2023
@gaspergrom gaspergrom merged commit 3118e41 into main Oct 20, 2023
7 checks passed
@gaspergrom gaspergrom deleted the bugfix/bot-settings-disabled-on-team-members branch October 20, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants