Skip to content

Commit

Permalink
dest should follow same convention as linux (#368)
Browse files Browse the repository at this point in the history
* dest should follow same convention as linux

The temp file path will be where the file is downloaded to. This
does not impact the name. If you have a url http://example.com/path/to/sensor.exe
then it will be falcon_windows_tmp_dir.path/sensor.exe

* add changelog to pr
  • Loading branch information
carlosmmatos authored Jul 28, 2023
1 parent 2fd8dc2 commit 0e04357
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions changelogs/fragments/url_ability_for_windows.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
minor_changes:
- falcon_install - add the ability to install from an URL for windows (https://github.com/CrowdStrike/ansible_collection_falcon/pull/363)

bugfixes:
- falcon_install - use tmp path instead of hardcoding sensor name (https://github.com/CrowdStrike/ansible_collection_falcon/pull/368)
2 changes: 1 addition & 1 deletion roles/falcon_install/tasks/win_url.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
- name: CrowdStrike Falcon | Downloading Installation Package from URL (Windows)
ansible.windows.win_get_url:
url: "{{ falcon_download_url }}"
dest: "{{ falcon_windows_tmp_dir }}\\falcon-sensor.exe"
dest: "{{ falcon_windows_tmp_dir.path }}"
url_username: "{{ falcon_download_url_username | default(omit) }}"
url_password: "{{ falcon_download_url_password | default(omit) }}"
when:
Expand Down

0 comments on commit 0e04357

Please sign in to comment.