-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sensor_download): add file operation support to module #485
fix(sensor_download): add file operation support to module #485
Conversation
Fixes CrowdStrike#481 This PR introduces the built-in files AnsibleModule helper features to manage file operations such as mode, owner, group, etc.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 37.75% 37.51% -0.24%
==========================================
Files 17 17
Lines 837 845 +8
Branches 161 162 +1
==========================================
+ Hits 316 317 +1
- Misses 520 527 +7
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the file mode example, 755 looks weird for a non-executable file.
@carlosmmatos I am glad that the module |
Dope 🤦🏻♂️. You're right, I was caught up in the process of updating the sensor module that I forgot that needs to be applied to the role. Apologies for that, I will have that out by end of day. |
Fixes #481
This PR introduces the built-in files AnsibleModule helper features to manage file operations such as mode, owner, group, etc.