-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create English subject page #4337
Open
joegibb
wants to merge
6
commits into
master
Choose a base branch
from
create-english-subject-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
Pull requests that update Ruby code
content
Content changes
labels
Nov 7, 2024
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
Sarah-DfE
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few little comments @joegibb looking good tho!
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/english/_article.html.erb
Outdated
Show resolved
Hide resolved
Review app deployed to https://get-into-teaching-app-review-4337.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/aOTV5CHu
Create a subject page for English