Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checkpoint_utils.py to match new web urls in pretrained_models.py #2061

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update checkpoint_utils.py to match new web urls in pretrained_models.py #2061

wants to merge 5 commits into from

Conversation

hannadiamond
Copy link

@hannadiamond hannadiamond commented Oct 23, 2024 •
edited
Loading

  • Update checkpoint_utils.py to match new web urls in pretrained_models.py
  • Fix unit tests that were trying to download from web urls leading no longer functioning s3 locations

@hannadiamond hannadiamond mentioned this pull request Oct 23, 2024
Open
BloodAxe
BloodAxe previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@hannadiamond
Copy link
Author

@BloodAxe
Updated to fix unit tests

If you can take a look again and approve that would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@BloodAxe BloodAxe Awaiting requested review from BloodAxe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannadiamond @BloodAxe