Skip to content

Commit

Permalink
remove now-redundant check for valid python identifiers in completion…
Browse files Browse the repository at this point in the history
…s now that the same change was made upstream
  • Loading branch information
DetachHead committed Nov 6, 2024
1 parent c83ffea commit de1267e
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ import {
} from './completionProviderUtils';
import { DocumentSymbolCollector } from './documentSymbolCollector';
import { getAutoImportText, getDocumentationPartsForTypeAndDecl } from './tooltipUtils';
import { Tokenizer } from '../parser/tokenizer';

namespace Keywords {
const base: string[] = [
Expand Down Expand Up @@ -2893,8 +2892,6 @@ export class CompletionProvider {
paramDetails.params.forEach((paramInfo) => {
if (
paramInfo.param.name &&
// filter out any dataclass field aliases that aren't valid identifiers
Tokenizer.isPythonIdentifier(paramInfo.param.name) &&
paramInfo.kind !== ParamKind.Positional &&
paramInfo.kind !== ParamKind.ExpandedArgs
) {
Expand Down

0 comments on commit de1267e

Please sign in to comment.