-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7117 Node Cluster Placement and Performance SPIKE #15384
Open
QilongTang
wants to merge
12
commits into
master
Choose a base branch
from
NodeClusterPlacementPerformance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7117
UI Smoke TestsTest: success. 11 passed, 0 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What I am doing in the PR:
With each double click on port, instead of regular Node AutoComplete, place triple nodes (a normal cluster size) and apply node preview states (a new node states other than Freeze/Warning/Error/Info/Dummy). Nodes in this state does not participate graph execution but can be displaced in canvas. In this example, they are three python nodes connected as a mock cluster.
With each double click on port, place a single node and freeze it, it would take ~10ms
With each double click on port, place triple nodes apply node preview state
It takes about 30ms to place nodes and put them into preview node state, it would take another 10ms if you want to make additional preview state rendering to connector
In a larger scaled graph, the time could increase to 40~50ms but it would still be quite smooth
The performance increase per cluster size is liner from my testing, also compared between what nodes included in cluster. But when I increase the cluster size to 10 and continue to create and then delete these nodes (which would be very close to what actually happens underneath the customer experience), my Dynamo session becomes slower and slower, after like 10 times. I suspect because of some kind of memory leak. With cluster getting actually placed in canvas and rotated for customer to pick, I think this is actually very likely to be a blocker for them especially when the cluster size is larger.
TODO:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of