Handle wait on the password login scene #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/password-wait
branch
from
b7d71ba
to
e69f42f
Compare
Jon-edge
approved these changes
Aug 22, 2024
swansontec
force-pushed
the
william/password-wait
branch
from
e69f42f
to
16c56f2
Compare
swansontec
force-pushed
the
william/password-wait
branch
from
16c56f2
to
6ccbfbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
This is a very bad PR. Ideally, we should be handling the wait with a countdown timer like we do on the PIN scene.
The current UI is leading users astray, so we want to get it fixed ASAP. We can maybe do a follow-up task to make this better.