Always create full account on PasswordLoginScene
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/always-create-full-acc
branch
from
cf72d70
to
96c77e7
Compare
6 tasks
Jon-edge
force-pushed
the
jon/always-create-full-acc
branch
2 times, most recently
from
47bca30
to
916bd79
Compare
swansontec
requested changes
Aug 27, 2024
| @@ -6,7 +6,6 @@ export type BiometryType = 'FaceID' | 'TouchID' | false | |||
| export type InitialRouteName = | |||
| | 'login' | |||
| | 'login-password' | |||
| | 'login-password-light' | |||
There was a problem hiding this comment.
This is a public API, so we can't really change it without a major version bump. So, instead of deleting it, just mark it with /** @deprecated Same as 'login-password' */, and then in the switch statement, you can just merge it with the 'login-password' case:
switch (imports.initialRoute) {
case 'login':
// ...
case 'login-password-light':
case 'login-password':
// visit password scene
case 'new-account':
// ...
}| @@ -69,12 +67,10 @@ export interface TouchIdInfo { | |||
| // | |||
|
|
|||
| export interface ExperimentConfig { | |||
| createAccountType: CreateAccountType | |||
There was a problem hiding this comment.
Deleting this public API is fine, since previous inputs would still be valid - we just ignore the unknown value.
Jon-edge
force-pushed
the
jon/always-create-full-acc
branch
from
916bd79
to
1918822
Compare
Jon-edge
force-pushed
the
jon/always-create-full-acc
branch
from
1918822
to
5ed5113
Compare
swansontec
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none