Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for working with binary indexes. #80

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add support for working with binary indexes. #80

wants to merge 15 commits into from

Commits on Mar 27, 2024

  1. Add support for BinaryIndexImpl, replicate and adapt core traits and … 

    …macros for binary indexes.

Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07 @CdnCentreForChildProtection
    aalekhpatel07 authored and CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ce7fdbb View commit details
    Browse the repository at this point in the history

  2. Add binary index cloning and creation to c_api 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07 @CdnCentreForChildProtection
    aalekhpatel07 authored and CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7cd358d View commit details
    Browse the repository at this point in the history

  3. Use SearchResultBinary and add IO functions for binary indexes. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07 @CdnCentreForChildProtection
    aalekhpatel07 authored and CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    29d435c View commit details
    Browse the repository at this point in the history

  4. Add a couple of tests for binary indexes 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07 @CdnCentreForChildProtection
    aalekhpatel07 authored and CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3d4c39d View commit details
    Browse the repository at this point in the history

  5. Temporarily enable CI for this PR 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07 @CdnCentreForChildProtection
    aalekhpatel07 authored and CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    aedd737 View commit details
    Browse the repository at this point in the history

  6. Expose the binary index related functions and traits via crate root

    @CdnCentreForChildProtection
    CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    05d92ab View commit details
    Browse the repository at this point in the history

  7. Revert "Temporarily enable CI for this PR"

    @CdnCentreForChildProtection
    CdnCentreForChildProtection committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6cf08a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Bump faiss submodule 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    33d8aea View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Comment out the concurrent binary impl macro 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    a021a9b View commit details
    Browse the repository at this point in the history

  2. Remove doctest of UpcastIndexBinary since there are no concrete binar… 

    …y indexes implemented yet.

Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    299d5fd View commit details
    Browse the repository at this point in the history

  3. Add a test for cloning binary indexes, and search binary indexes. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    dbe4f6d View commit details
    Browse the repository at this point in the history

  4. Try another dimension value for index. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    d71119c View commit details
    Browse the repository at this point in the history

  5. Rustfmt fixes. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    698c65a View commit details
    Browse the repository at this point in the history

  6. Update impl_native_binary_index macro to do proper accounting of the … 

    …vectors.

Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    c1d8c08 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'master' into binary-indexes

    @aalekhpatel07
    aalekhpatel07 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d35707a View commit details
    Browse the repository at this point in the history