Add algorithm options of KNeighborRegressor/Classifier; Add SelectFdr to selectors #1350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
config/regressor.py
config/classifier.py
How should this PR be tested?
Existing KNeighborRegressor tests should pass.
Adding an option to select by FDR.
Both have been tested in my hands extensively without any problems.
Any background context you want to provide?
When running nosetests with scikit-learn 1.4.2, export tests fail due to a deprecated function usage which is not related to this PR. All other tests pass.
What are the relevant issues?
[you can link directly to issues by entering # then the number of the issue, for example, #3 links to issue 3]
Screenshots (if appropriate)
Questions:
Addition of selectFdr to documentation
Maybe addition of algorithm details for KNeighborRegressor and KNeighborClassifier
If this is deemed an acceptable contribution, I'm happy to update other code in the config directory.