Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to allow multioutput. #903

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mpdunne
Copy link

@mpdunne mpdunne commented Aug 14, 2019

[please review the Contribution Guidelines prior to submitting your pull request. go ahead and delete this line if you've already reviewed said guidelines.]

What does this PR do?

Allows multi-output models to run with TPOT.

Where should the reviewer start?

It's only a couple of small changes.

How should this PR be tested?

Try running TPOT with this flag. See if anything breaks.

Any background context you want to provide?

Not all SK models support multiple regression. Therefore the user should also add MultiOutputRegressor in the config if they want to maximise the utility of the change.

What are the relevant issues?

#747
#810

[you can link directly to issues by entering # then the number of the issue, for example, #3 links to issue 3]

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated? - Yes.
  • Does this PR add new (Python) dependencies? - No.

@weixuanfu weixuanfu changed the base branch from master to development August 14, 2019 13:11
@weixuanfu
Copy link
Contributor

Thank you for this PR. The unit tests should pass but it failed due to installation of latest dask in CI environment. I will fix this issue in #904 and merge it to dev branch soon.

@coveralls
Copy link

coveralls commented Aug 14, 2019

Coverage Status

Coverage increased (+0.1%) to 96.135% when pulling e9c31c9 on mpdunne:multi_output into 24b4374 on EpistasisLab:development.

@weixuanfu weixuanfu changed the base branch from development to master August 14, 2019 16:47
@weixuanfu weixuanfu changed the base branch from master to development August 14, 2019 16:47
@kradant kradant mentioned this pull request Dec 3, 2019
@weixuanfu
Copy link
Contributor

I am sorry for overlooking this issue for a while. I think a nicer solution is to let TPOT check y's shape to determine if TPOT is running on a multi-output problem and then switch configuration to Regressors which naively supports multi-output problems. Then the new parameter multi-output is not needed. Could you please make a update to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants