[WEEKLY RELEASE] HotShot - 0.5.73 (#3624)

* bump version to 0.5.73

* update cargo.lock

* turn off enable_registration_verification

* restore enable_registration_verification to true

* latest main

* clippy

* clippy

Cargo.toml

@@ -1,5 +1,5 @@
 [workspace.package]
-version = "0.5.72" # same as `hotshot`, but workspace subcrate can also release its own version
+version = "0.5.73" # same as `hotshot`, but workspace subcrate can also release its own version
 authors = ["Espresso Systems <hello@espressosys.com>"]
 edition = "2021"
 rust-version = "1.76.0"
@@ -162,8 +162,8 @@ incremental = true
 
 [workspace.lints.clippy]
 # warns
-all = "warn"
-pedantic = "warn"
+all = { level = "warn", priority = -1 }
+pedantic = { level = "warn", priority = -1 }
 missing_docs_in_private_items = "warn"
 panic = "warn"
 clone_on_ref_ptr = "warn"
@@ -173,7 +173,7 @@ module_name_repetitions = "allow"
 
 [workspace.lints.rust]
 # warns
-rust_2018_idioms = "warn"
+rust_2018_idioms = { level = "warn", priority = -1 }
 # TODO change to deny
 missing_docs = "warn"
 warnings = "warn"

crates/hotshot/src/tasks/mod.rs

@@ -381,7 +381,7 @@ where
         // spawn a task to listen on the (original) internal event stream,
         // and broadcast the transformed events to the replacement event stream we just created.
         let shutdown_signal = create_shutdown_event_monitor(handle).fuse();
-        let public_key = handle.public_key();
+        let public_key = handle.public_key().clone();
         let private_key = handle.private_key().clone();
         let upgrade_lock = handle.hotshot.upgrade_lock.clone();
         let send_handle = async_spawn(async move {

crates/macros/src/lib.rs

@@ -275,7 +275,7 @@ fn cross_tests_internal(test_spec: CrossTestData) -> TokenStream {
 /// - `Types: []` - a list types that implement `NodeImplementation` over the types in `Impls`
 /// - `TestName: example_test` - the name of the test
 /// - `Ignore`: whether or not this set of tests are ignored
-/// Example usage: see tests in this module
+///   Example usage: see tests in this module
 #[proc_macro]
 pub fn cross_tests(input: TokenStream) -> TokenStream {
     let test_spec = parse_macro_input!(input as CrossTestData);