Use getControllerClass() instead of getController() #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
route()->getController()
is completely unsafe to use if the route uses a closure, and route()->isControllerAction() is protected. This leads to errors likeBindingResolutionException: Target class [] does not exist.
if a tool uses closures instead of controllers as they are turned into serialized closures. Therefore, the following code does not handle the cases correctly:The function
getControllerClass()
is protected by the following function (inIlluminate\Routing\Route
):I have rewritten the two occurrences of
route()->getController()
to usegetControllerClass()
instead.Reference: wdelfuego/nova-calendar#41 (comment)