Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triomphe impl #216

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

novacrazy
Copy link

No description provided.

@novacrazy novacrazy marked this pull request as draft May 11, 2023 00:17
@novacrazy novacrazy marked this pull request as ready for review May 11, 2023 00:21
@novacrazy
Copy link
Author

Had a bit of last-second panic that perhaps the other, more exotic Arc types could potentially have JsonSchema be applied to them as well, but only the main Arc type implements the serde traits so this works fine. My apologies.

@novacrazy
Copy link
Author

Looks like there is a 1.0 alpha now. I'll rebase this soon in hopes of getting it into 1.0, over a year later.

@novacrazy
Copy link
Author

Some automatic formatting made it into the merge, but oh well. Should be good now if the tests pass.

@novacrazy
Copy link
Author

Oh, there is a failure on the version, as triomphe requires rustc 1.76 or higher. I'll leave it your discretion if that's allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant