Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital-38: migrate shortcodes templates #36

Merged
merged 42 commits into from
Nov 12, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 7, 2024

Jira ticket

DIGITAL-

Purpose

This Pr will set up shortcode templates and update to match Drupal fields. Also updated PHP files as needed and broke out several short codes into small ones to address special use cases.

Includes the following PRs that must be merged first

n/a

Deployment and testing

Local Setup

lando rebuild && lando si

QA/Testing instructions

  1. create a new content type and fill out each shortcode
  2. verify that the overall look and function is matching as expect

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review November 8, 2024 16:13
@mattsqd mattsqd merged commit d96af1e into develop Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants