refactor miscellaneous daos and utilities #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2024 10:02
added 2 commits
October 17, 2024 12:10
7 tasks
terrazoon
changed the title
xlorepdarkhelm
previously requested changes
Oct 22, 2024
added 2 commits
October 24, 2024 07:14
ccostino
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Thanks, @terrazoon! One quick question on another print statement but otherwise all is good!
added 2 commits
October 29, 2024 14:29
ccostino
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks, @terrazoon! 🎉
@xlorepdarkhelm, looks like you need to review again as well. 🙂
A-Shumway42
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade inbound_number_dao, inbound_sms_dao, complaint_dao, etc. to sqlalchemy 2.0
Security Considerations
N/A