-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production deploy 9/18/23 #475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notify-api-59 make command to create new service
notify-300 set total message limit to 250k for pilot
Insert total_message_limit into service creation
Bump gitpython from 3.1.32 to 3.1.34
Add ADR 0006: Use `poetry` for dependency management
Switch branch of ADR action
Update ADR process
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.34 to 3.1.35. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](gitpython-developers/GitPython@3.1.34...3.1.35) --- updated-dependencies: - dependency-name: gitpython dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump gitpython from 3.1.34 to 3.1.35
Bumps [pytest-env](https://github.com/pytest-dev/pytest-env) from 0.6.2 to 1.0.1. - [Release notes](https://github.com/pytest-dev/pytest-env/releases) - [Commits](pytest-dev/pytest-env@0.6.2...1.0.1) --- updated-dependencies: - dependency-name: pytest-env dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bump pytest-env from 0.6.2 to 1.0.1
Bumps [notifications-python-client](https://github.com/alphagov/notifications-python-client) from 6.3.0 to 8.0.1. - [Changelog](https://github.com/alphagov/notifications-python-client/blob/main/CHANGELOG.md) - [Commits](alphagov/notifications-python-client@6.3.0...8.0.1) --- updated-dependencies: - dependency-name: notifications-python-client dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…client-8.0.1 Bump notifications-python-client from 6.3.0 to 8.0.1
add migration for e2e tests and improve code coverage
Switch ADMIN_BASE_URL to fancier URL
This changest updates the Invite Expirations ADR (ADR-0003) to become accepted and ready for implementation. It also updates the index with recent ADR changes prior to the ADR process updates. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Update ADR-0003 (Invite Expirations)
This changeset adds a migration to add a default total message limit to any pre-existing service that does not already have one set. It bases this value on the default set in the Flask app config. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
h/t to @stvnrlly for the catch! Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Add total message limit default to existing services
ccostino
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for prepping this, @stvnrlly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
poetry
(poetry #454 )total_message_limit
and enforce upper message limit for services (notify-300 set total message limit to 250k for pilot #252 Insert total_message_limit into service creation #458 Add total message limit default to existing services #476 )Minor changes