Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod deploy - 4/3/24 #892

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Prod deploy - 4/3/24 #892

merged 4 commits into from
Apr 3, 2024

Conversation

stvnrlly
Copy link
Collaborator

@stvnrlly stvnrlly commented Apr 3, 2024

A mini-deploy to unstick Terraform and get the previous deploy flowing.

ccostino and others added 2 commits April 3, 2024 12:57
@ccostino
Revert recent Terraform changes to prod and demo
ead7e38 
This changeset reverts a few of our recent changes to the production and demo Terraform files to re-enable deployments.

We are working through fixing this and will re-introduce these changes once we figure out how to get the changes to properly work (which are tied to the infrastructure checks as well).

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
@stvnrlly
Merge pull request #891 from GSA/revert-recent-terraform
ecbe736 
Revert recent Terraform changes to prod and demo
@stvnrlly stvnrlly requested a review from ccostino April 3, 2024 17:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Terraform Format and Style: success
Terraform Initialization: failure
Terraform Validation: skipped
Terraform Plan: skipped

Show Plan

Pusher: @stvnrlly, Action: pull_request

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Terraform Format and Style: success
Terraform Initialization: failure
Terraform Validation: skipped
Terraform Plan: skipped

Show Plan

Pusher: @stvnrlly, Action: pull_request

ccostino
ccostino previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 thanks @stvnrlly!

ccostino and others added 2 commits April 3, 2024 14:07
@ccostino
Revert the rest of our Terraform changes
af877ca 
This changeset reverts the rest of our recent Terraform changes to make sure deployments are working properly.

Again, these will be re-introduced once we figure out the resource management piece.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
@stvnrlly
Merge pull request #893 from GSA/revert-rest-of-terraform
69c4066 
Revert the rest of our Terraform changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan 

module.redis.data.cloudfoundry_service.redis: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket.data.cloudfoundry_space.space: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.egress-space.data.cloudfoundry_org.org: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.ses_email.data.cloudfoundry_service.ses: Reading...
module.database.data.cloudfoundry_space.space: Reading...
module.egress-space.data.cloudfoundry_org.org: Read complete after 1s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.database.data.cloudfoundry_service.rds: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 1s [id=37cbe836-d604-45d1-b1f8-1403f7cb3ff7]
module.egress-space.data.cloudfoundry_user.users["dd4002f6-951d-44b2-b88c-1b828e98dc01"]: Reading...
module.ses_email.data.cloudfoundry_service.ses: Read complete after 1s [id=8bf5287d-587b-4696-8e53-a6ffdba211c0]
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=63506464-c7e2-4743-a7b3-4a8d45f14fb9]
module.csv_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.sns_sms.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=ccaf756d-74a2-4903-b9cf-08ad0123ecbc]
module.database.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.ses_email.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=36cf8e1d-f2b7-4b44-9ef6-998393cb547f]
module.database.data.cloudfoundry_service.rds: Read complete after 0s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=6267206c-b5ab-4dbb-8662-02f2ada85876]
module.csv_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=0d3aa4e5-7e26-4eef-bf6a-f12818b8a687]
module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=ccb2abc6-1986-4c55-b8cf-d21e313f26c2]
module.egress-space.data.cloudfoundry_user.users["dd4002f6-951d-44b2-b88c-1b828e98dc01"]: Read complete after 0s [id=c51e169a-d8d0-4179-adff-ef871ba9e8ae]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=11c85b1d-3895-b7a0-260c-a036d272226d]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.egress-space.cloudfoundry_space.public_egress will be updated in-place
  ~ resource "cloudfoundry_space" "public_egress" {
      + delete_recursive_allowed = true
        id                       = "63506464-c7e2-4743-a7b3-4a8d45f14fb9"
        name                     = "notify-production-egress"
        # (7 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.ses_email.cloudfoundry_service_instance.ses,
  on ../shared/ses/main.tf line 22, in resource "cloudfoundry_service_instance" "ses":
  22:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 4 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @stvnrlly, Action: pull_request

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan 

module.csv_upload_bucket.data.cloudfoundry_space.space: Reading...
module.database.data.cloudfoundry_service.rds: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.egress-space.data.cloudfoundry_org.org: Reading...
module.database.data.cloudfoundry_space.space: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_service.ses: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 0s [id=ed5b0e74-dacc-4511-8514-410bef51b554]
module.redis.data.cloudfoundry_service.redis: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.ses_email.data.cloudfoundry_service.ses: Read complete after 0s [id=8a75c59c-0c4b-4764-907c-b0760c7278a0]
module.database.data.cloudfoundry_service.rds: Read complete after 0s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.egress-space.data.cloudfoundry_org.org: Read complete after 0s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.egress-space.data.cloudfoundry_user.users["bbb35677-6906-4f8d-b230-bb4755d7886a"]: Reading...
module.egress-space.data.cloudfoundry_user.users["steven.reilly@gsa.gov"]: Reading...
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=fa2417a9-297e-40e0-a517-f4f1f4989556]
module.csv_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=59028298-4427-4516-907d-097d99dda5c5]
module.redis.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.sns_sms.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=dfa60432-eab1-456b-8a24-9a34312939ed]
module.ses_email.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=a113b8a3-5a87-4920-85c6-00c18a8c389e]
module.database.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=9360890e-0458-41d0-99ce-071ce7f5bef9]
module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=c6d73ed7-69ba-4720-a459-7b80200006c8]
module.egress-space.data.cloudfoundry_user.users["steven.reilly@gsa.gov"]: Read complete after 0s [id=ffd00a3e-aa1a-42e1-a81a-5f60420658c2]
module.egress-space.data.cloudfoundry_user.users["bbb35677-6906-4f8d-b230-bb4755d7886a"]: Read complete after 0s [id=74b9cc1c-d8fa-4e70-8eba-c7d66343ad9c]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=63a559ae-ceb6-3066-9eb0-b57347e2bece]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.egress-space.cloudfoundry_space.public_egress will be updated in-place
  ~ resource "cloudfoundry_space" "public_egress" {
      + delete_recursive_allowed = true
        id                       = "fa2417a9-297e-40e0-a517-f4f1f4989556"
        name                     = "notify-demo-egress"
        # (7 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.ses_email.cloudfoundry_service_instance.ses,
  on ../shared/ses/main.tf line 22, in resource "cloudfoundry_service_instance" "ses":
  22:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 4 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @stvnrlly, Action: pull_request

@ccostino ccostino merged commit f1d190d into production Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccostino ccostino ccostino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stvnrlly @ccostino